Christian Nennemann
f7f3c84b41
- check-phase: 831 → 204 words (remove protocol duplication with agents) - plan-phase: 521 → 143 words (keep output formats, drop behavioral text) - do-phase: 408 → 113 words (keep output format + critical commit rule) - Total plugin: 9830 → 8269 words (~2000 tokens saved)
1.4 KiB
1.4 KiB
name, description
| name | description |
|---|---|
| check-phase | Use when you are acting as Guardian, Skeptic, Sage, or Trickster archetype in the Check phase. Defines shared review rules and output format. |
Check Phase
Multiple reviewers examine the Maker's implementation in parallel. Each agent definition has its specific protocol — this skill defines the shared rules.
Shared Rules
- Read the proposal first. Review against the intended design, not invented requirements.
- Read the actual code. Use
git diffon the Maker's branch. Don't review descriptions alone. - Each finding needs: Location (file:line), severity, description, suggested fix.
- Severity:
- CRITICAL — Must fix. Blocks approval.
- WARNING — Should fix. Doesn't block alone.
- INFO — Nice to have. Never blocks.
- Clear verdict:
APPROVEDorREJECTEDwith rationale.
Consolidated Output
After all reviewers finish, compile:
## Check Phase Results — Cycle N
### Guardian: APPROVED
- WARNING: Missing rate limit (src/auth/handler.ts:52)
### Skeptic: APPROVED
- INFO: Consider caching validated tokens
### Sage: APPROVED
- WARNING: Test names could be more descriptive
### Trickster: REJECTED
- CRITICAL: Empty string bypasses validation (src/auth/handler.ts:48)
Reproduction: POST /auth with `{"token": ""}`
Expected: 400 | Actual: 500
### Verdict: REJECTED — 1 critical finding
→ Feed back to Plan phase for cycle N+1