fix: unify feedback routing tables across orchestration, act-phase, artifact-routing

This commit is contained in:
2026-04-04 07:32:47 +02:00
parent 6bc5e48357
commit 2247e52ae4
3 changed files with 27 additions and 17 deletions

View File

@@ -286,18 +286,20 @@ When cycling back, produce `act-feedback.md` as a structured handoff. This repla
| — | — | — | — | — | | — | — | — | — | — |
``` ```
**Routing rules** (same as orchestration skill, repeated here for self-containment): **Routing rules** (canonical table — matches orchestration and artifact-routing skills):
| Finding Source | Routes to | When | | Source | Category | Routes to | Reason |
|----------------|-----------|------| |--------|----------|-----------|--------|
| Guardian (security, breaking-change) | Creator | Design must change | | Guardian | security, breaking-change | Creator | Design must change |
| Skeptic (design, scalability) | Creator | Assumptions need revision | | Guardian | reliability, dependency | Creator | Architectural decision needed |
| Sage (quality, consistency) | Maker | Implementation refinement | | Skeptic | design, scalability | Creator | Assumptions need revision |
| Sage (design) | Creator | If it's an architectural concern | | Sage | quality, consistency | Maker | Implementation refinement |
| Trickster (reliability) | Creator | If root cause is a design flaw | | Sage | testing | Maker | Test gap, not design flaw |
| Trickster (testing) | Maker | If root cause is a test gap | | Trickster | reliability (design flaw) | Creator | Needs redesign |
| Trickster | reliability (test gap) | Maker | Needs more tests |
| Trickster | testing | Maker | Edge case not covered |
When in doubt about routing: if the fix requires changing the approach, route to Creator. If the fix requires changing the code within the existing approach, route to Maker. **Disambiguation rule:** When in doubt: if the fix requires changing the approach, route to Creator. If it requires changing the code within the existing approach, route to Maker.
--- ---

View File

@@ -164,6 +164,8 @@ No agents are spawned in Act. The orchestrator reads all `check-*.md` artifacts
## Feedback Routing ## Feedback Routing
> **This is the canonical routing table.** Other skills (orchestration, act-phase) must match this table exactly. When updating routing rules, update this table first, then sync the others.
When building `act-feedback.md` after the Check phase, route each finding to the right agent for the next cycle: When building `act-feedback.md` after the Check phase, route each finding to the right agent for the next cycle:
| Finding Source | Finding Category | Routes To | Rationale | | Finding Source | Finding Category | Routes To | Rationale |
@@ -177,7 +179,7 @@ When building `act-feedback.md` after the Check phase, route each finding to the
| Trickster | reliability (test gap) | **Maker** | Needs more tests | | Trickster | reliability (test gap) | **Maker** | Needs more tests |
| Trickster | testing | **Maker** | Edge case not covered | | Trickster | testing | **Maker** | Edge case not covered |
**Ambiguous cases:** If a Trickster finding could be either a design flaw or a test gap, check: does the fix require changing the proposal's architecture/approach, or just adding a test/validation? Architecture change → Creator. Additional test → Maker. **Disambiguation rule:** When in doubt: if the fix requires changing the approach, route to Creator. If it requires changing the code within the existing approach, route to Maker.
### Feedback File Format ### Feedback File Format

View File

@@ -344,12 +344,18 @@ Parse each reviewer's output into the standardized format:
Not all findings go to the same agent: Not all findings go to the same agent:
| Finding source | Routes to | Rationale | | Source | Category | Routes to | Reason |
|----------------|-----------|-----------| |--------|----------|-----------|--------|
| Guardian (security, breaking-change) | **Creator** | Design must change | | Guardian | security, breaking-change | **Creator** | Design must change |
| Skeptic (design, scalability) | **Creator** | Assumptions need revision | | Guardian | reliability, dependency | **Creator** | Architectural decision needed |
| Sage (quality, consistency) | **Maker** | Implementation refinement | | Skeptic | design, scalability | **Creator** | Assumptions need revision |
| Trickster (reliability, testing) | **Creator** if design flaw, **Maker** if test gap | Depends on root cause | | Sage | quality, consistency | **Maker** | Implementation refinement |
| Sage | testing | **Maker** | Test gap, not design flaw |
| Trickster | reliability (design flaw) | **Creator** | Needs redesign |
| Trickster | reliability (test gap) | **Maker** | Needs more tests |
| Trickster | testing | **Maker** | Edge case not covered |
**Disambiguation rule:** When in doubt: if the fix requires changing the approach, route to Creator. If it requires changing the code within the existing approach, route to Maker.
### 3. Track Resolution ### 3. Track Resolution