diff --git a/skills/act-phase/SKILL.md b/skills/act-phase/SKILL.md index edc8232..e3be23b 100644 --- a/skills/act-phase/SKILL.md +++ b/skills/act-phase/SKILL.md @@ -286,18 +286,20 @@ When cycling back, produce `act-feedback.md` as a structured handoff. This repla | — | — | — | — | — | ``` -**Routing rules** (same as orchestration skill, repeated here for self-containment): +**Routing rules** (canonical table — matches orchestration and artifact-routing skills): -| Finding Source | Routes to | When | -|----------------|-----------|------| -| Guardian (security, breaking-change) | Creator | Design must change | -| Skeptic (design, scalability) | Creator | Assumptions need revision | -| Sage (quality, consistency) | Maker | Implementation refinement | -| Sage (design) | Creator | If it's an architectural concern | -| Trickster (reliability) | Creator | If root cause is a design flaw | -| Trickster (testing) | Maker | If root cause is a test gap | +| Source | Category | Routes to | Reason | +|--------|----------|-----------|--------| +| Guardian | security, breaking-change | Creator | Design must change | +| Guardian | reliability, dependency | Creator | Architectural decision needed | +| Skeptic | design, scalability | Creator | Assumptions need revision | +| Sage | quality, consistency | Maker | Implementation refinement | +| Sage | testing | Maker | Test gap, not design flaw | +| Trickster | reliability (design flaw) | Creator | Needs redesign | +| Trickster | reliability (test gap) | Maker | Needs more tests | +| Trickster | testing | Maker | Edge case not covered | -When in doubt about routing: if the fix requires changing the approach, route to Creator. If the fix requires changing the code within the existing approach, route to Maker. +**Disambiguation rule:** When in doubt: if the fix requires changing the approach, route to Creator. If it requires changing the code within the existing approach, route to Maker. --- diff --git a/skills/artifact-routing/SKILL.md b/skills/artifact-routing/SKILL.md index b75a1ca..db7b9aa 100644 --- a/skills/artifact-routing/SKILL.md +++ b/skills/artifact-routing/SKILL.md @@ -164,6 +164,8 @@ No agents are spawned in Act. The orchestrator reads all `check-*.md` artifacts ## Feedback Routing +> **This is the canonical routing table.** Other skills (orchestration, act-phase) must match this table exactly. When updating routing rules, update this table first, then sync the others. + When building `act-feedback.md` after the Check phase, route each finding to the right agent for the next cycle: | Finding Source | Finding Category | Routes To | Rationale | @@ -177,7 +179,7 @@ When building `act-feedback.md` after the Check phase, route each finding to the | Trickster | reliability (test gap) | **Maker** | Needs more tests | | Trickster | testing | **Maker** | Edge case not covered | -**Ambiguous cases:** If a Trickster finding could be either a design flaw or a test gap, check: does the fix require changing the proposal's architecture/approach, or just adding a test/validation? Architecture change → Creator. Additional test → Maker. +**Disambiguation rule:** When in doubt: if the fix requires changing the approach, route to Creator. If it requires changing the code within the existing approach, route to Maker. ### Feedback File Format diff --git a/skills/orchestration/SKILL.md b/skills/orchestration/SKILL.md index 306481e..9d0cd07 100644 --- a/skills/orchestration/SKILL.md +++ b/skills/orchestration/SKILL.md @@ -344,12 +344,18 @@ Parse each reviewer's output into the standardized format: Not all findings go to the same agent: -| Finding source | Routes to | Rationale | -|----------------|-----------|-----------| -| Guardian (security, breaking-change) | **Creator** | Design must change | -| Skeptic (design, scalability) | **Creator** | Assumptions need revision | -| Sage (quality, consistency) | **Maker** | Implementation refinement | -| Trickster (reliability, testing) | **Creator** if design flaw, **Maker** if test gap | Depends on root cause | +| Source | Category | Routes to | Reason | +|--------|----------|-----------|--------| +| Guardian | security, breaking-change | **Creator** | Design must change | +| Guardian | reliability, dependency | **Creator** | Architectural decision needed | +| Skeptic | design, scalability | **Creator** | Assumptions need revision | +| Sage | quality, consistency | **Maker** | Implementation refinement | +| Sage | testing | **Maker** | Test gap, not design flaw | +| Trickster | reliability (design flaw) | **Creator** | Needs redesign | +| Trickster | reliability (test gap) | **Maker** | Needs more tests | +| Trickster | testing | **Maker** | Edge case not covered | + +**Disambiguation rule:** When in doubt: if the fix requires changing the approach, route to Creator. If it requires changing the code within the existing approach, route to Maker. ### 3. Track Resolution